The current shop I work in uses TURNOVER and I wished they would handle it your way Eric.
I get really tired looking at code like......
C Exsr Subroutine
****************************
C Begsr Subroutine
C*Twenty lines of code comment out
C*
C* Then bad comments like....
C*
C*This line makes Nothing = Nothing
C*
C Eval Something = Something
C*
C*Twenty lines of code comment out
C*
C Endsr Subroutine
*****************************
When it could have just been changed to
C Eval Something = Something
In place of
C Exsr Subroutine
And delete everything else.
Regards,
Bill Hopkins
-----Original Message-----
From: midrange-l-bounces@xxxxxxxxxxxx [mailto:midrange-l-bounces@xxxxxxxxxxxx] On Behalf Of DeLong, Eric
Sent: Friday, September 27, 2013 12:55 PM
To: Midrange Systems Technical Discussion
Subject: RE: Documenting code changes
Hi Cyndi,
I'm afraid I haven't needed to bother with that for some time now... We do put comment tags at the top, and some developers will leave commented out lines in source, but my policy is, once we know that the program has stabilized, then the commented lines get ripped out.
I use our change management software to track the deltas, as each version of the source is retained by the source archives in TurnOver. The product exposes the source compare features to these source archives, allowing easy review of the actual source changes involved in each change ticket. I think it's much easier to work with clean source.
-Eric DeLong
-----Original Message-----
From: midrange-l-bounces@xxxxxxxxxxxx [mailto:midrange-l-bounces@xxxxxxxxxxxx] On Behalf Of Cyndi Bradberry
Sent: Friday, September 27, 2013 10:55 AM
To: 'Midrange Systems Technical Discussion'
Subject: Documenting code changes
Hi,
In the past, we have documented at the top of the program the date, ticket # and a description of a change. Now we are being told to put the ticket number in the first 5 positions, copy the line we are changing, commenting out the original line and editing the new. In CLP, /* */ to enclose the ticket number on the line being changed.
But I cannot get anyone to explain how long this remains in the code. I don't have a problem with commenting out and entering new lines, but when I go in to maintain the program next, I generally want to clean up (delete) the unused lines of code to make for better readability. When making large changes, I also make backup copies of the source member just in case I have to go backwards.
Can anyone point me to a best practices for documenting code changes ? This would have to cover RPG IV and Free and CL programs. We are working towards a SOC 2 Type 1 compliance.
TIA,
Cyndi B.
Boise, ID
--
This is the Midrange Systems Technical Discussion (MIDRANGE-L) mailing list To post a message email: MIDRANGE-L@xxxxxxxxxxxx To subscribe, unsubscribe, or change list options,
visit:
http://lists.midrange.com/mailman/listinfo/midrange-l
or email: MIDRANGE-L-request@xxxxxxxxxxxx Before posting, please take a moment to review the archives at
http://archive.midrange.com/midrange-l.
--
This is the Midrange Systems Technical Discussion (MIDRANGE-L) mailing list To post a message email: MIDRANGE-L@xxxxxxxxxxxx To subscribe, unsubscribe, or change list options,
visit:
http://lists.midrange.com/mailman/listinfo/midrange-l
or email: MIDRANGE-L-request@xxxxxxxxxxxx Before posting, please take a moment to review the archives at
http://archive.midrange.com/midrange-l.
As an Amazon Associate we earn from qualifying purchases.