Re: Programing requirements - Guidelines - Code Revision and External Programmers - Am I wrong

On 3/5/2013 1:21 AM, Birgitta Hauser wrote:

Do not want to start a never ending discussions but only get a few opinions.

-snip description of shop programming guidelines-

I rejected the enhancements because they do not conform to the guidelines.
The comment of the programmer was: it works and why I should not snooping
through his sources. He could not understand why I'm trying to play the
boss. If I think I can it better I should do it myself.

Am I really wrong insisting in the programming guidelines are followed?
IMHO "working" is not all, also the source code must be documented and
conform the guidelines.

I deliberately snipped the guidelines because whether I think they are
good or bad is irrelevant. I always follow shop standards even if I
disagree with them. I follow shop standards because they make it easier
for every programmer to work on every program. My current employer has
no shop standards, formal or informal. Even in this case, when I am
working in a program written by a colleague, I emulate her style so that
the overall style of the program remains the way it was.

If you hired me to work on your system and explained the shop standards
to me and I blatantly ignored those standards, I should be dismissed.
'Working code' is important, but being able to integrate that working
code with the existing code base is important too. As is the ability
for an employee to cooperate with the other employees.
--buck