Re: Code reviews (was: Saving the System i: Fight Rather Than Switch)

[Mike <koldark@xxxxxxxxx>]

Besides the issues that David mentioned, I think code reviews are best for
the newer programmers. You can then show them "a better way" to do things
and teach them in the process.

On 12/15/06, David Gibbs <david@xxxxxxxxxxxx> wrote:
> albartell wrote:
> > How many of the IT managers on this list do programmer reviews of code
> on a
> > regular basis?
>
> I wouldn't actually expect an IT manager to do a code review ... code
> reviews require technical expertise ... and, while some managers do have
> the expertise, a significant number don't.  But I wouldn't really expect
> a manager to be as current on technical matters as a programmer.
>
> In our shop, small as it is, we have peers do the code reviews.
>
> Problem is ... how much can you catch in a code review?  Adherence to
> standards: yes, documentation: yes, change control policies followed:
> Yes (well Duh!).  But that's pretty much it.  You can't catch logic
> errors with a code review, unless they are blatant.
>
> david
> --
> This is the Midrange Systems Technical Discussion (MIDRANGE-L) mailing
> list
> To post a message email: MIDRANGE-L@xxxxxxxxxxxx
> To subscribe, unsubscribe, or change list options,
> visit: http://lists.midrange.com/mailman/listinfo/midrange-l
> or email: MIDRANGE-L-request@xxxxxxxxxxxx
> Before posting, please take a moment to review the archives
> at http://archive.midrange.com/midrange-l.