RE: DSPRCDFMT from News/400?

On Tue, 12 Aug 2003, Art Tostaine, Jr. wrote:
>
> Here's the complete source.  It works on my V5R1 machine.
>
[SNIP]

There are two lines of code in this program that look like they could
be causing release compatibility issues.  If they aren't, they will
eventually.  :)

The first one is here:

     C                   eval      SpaceStart = 513

This number should not be hardcoded to a value.  It should be retrieved
from data in the user space.  Otherwise, if IBM adds any new data to the
header area of the space, it'll cause an incompatibility.

Presumably, he should be using the OffsetDBR field which he's even using
for the data base relations API, and just not for the list fields API,
which really bugs me :(

The other one is here:
     C                   eval      SpaceStart = (SpaceStart + DataSize)

He's adding "DataSize" (which is the size of his data structure) to the
space start.  That's not right.  He should be adding the Entry Size to
his start position, not the size of his data structure.   Otherwise, if
IBM adds any new fields into the per-entry data, it'd break compatibility.

Since I don't have the rest of this code (the screen DDS, the files, the
command, etc) I can't change it and compile/run it... therefore I don't
know if that really solves the problem.

But, those things just jump out at me as being "timebombs"