|
Hello Russ, Well said! Not enough shops (in fact, sod all) perform peer reviews. They all should (except possibly one-man shops) because (in no particular order): 1/ It ensures shop standards are met. 2/ It ensures the program is reasonably close to the specification 3/ It allows junior programmers to learn from the more experienced ("Oh, yeah, that was a bit silly wasn't it?") 4/ It allows senior programers to learn from the juniors ("When did that op-code appear?") There should be reviews at all stages of development: a/ Specification review b/ Pseudo code review c/ Code review d/ test plan review Of course all this needs to be budgeted and persuading management that it's necessary is harder than it should be. Regards, Simon Coulter. «»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«» «» FlyByNight Software AS/400 Technical Specialists «» «» Eclipse the competition - run your business on an IBM AS/400. «» «» «» «» Phone: +61 3 9419 0175 Mobile: +61 0411 091 400 «» «» Fax: +61 3 9419 0175 mailto: shc@flybynight.com.au «» «» «» «» Windoze should not be open at Warp speed. «» «»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«»«» //--- forwarded letter ------------------------------------------------------- > X-Mailer: Microsoft Outlook 8.5, Build 4.71.2173.0 > MIME-Version: 1.0 > Date: Sat, 27 Mar 99 16:38:08 -0500 > From: "rpopeil" <Russ.Popeil@ac.avnet.com> > To: MIDRANGE-L@midrange.com > Reply-To: MIDRANGE-L@midrange.com > Subject: RE: IBM pushing Java > Importance: Normal > > his seems more a need of shop standards and programmer management, and code > reviews alas not usually done in small shops. > > Russ Popeil > IBM Certified Specialist > Avnet Computer > You've Got our Word on IT™. > Office: 516-677-9346 Fax: 516-677-0296 > Pager: 800-759-8888 Pin: 1651954 > Pager eMail: 1651954@skytel.com > eMail: Russ.Popeil@avnet.com > http://www.avnetcomputer.com > > > > > -----Original Message----- > From: owner-midrange-l@midrange.com > [mailto:owner-midrange-l@midrange.com]On Behalf Of nina jones > Sent: Saturday, March 27, 1999 12:52 PM > To: MIDRANGE-L@midrange.com > Subject: Re: IBM pushing Java > > > > other hand, some languages lend themselves to this better than others. > > As an example, I remember a COBOL program written by a fellow student > > in university 20 years ago. It was the most easy to read program I'd > > ever seen and there were no comments in it. This student graduated > > at the top of his class and I doubt if he ever wrote another COBOL > > program since! > > i think some people's programming style is easier to follow than others. > doesn't > really matter on the language. well, maybe some! > > years ago, we inherited a client that used a lady that did not do anything > straight forward. in frustration, once i asked how on earth she handled > fixing > problems. they said she'd list her programs, go in the conference room, > spread > them out, and color code them. > > i like code that you can look at and follow, that has relevent, up to date > comments - with explainations before major sections of code as to what it's > for, > and routines sectioned off. and one more pet peeve - old commented out > code. if > you don't need it, get rid of it! > > this week i was in california, and had to debug a program written by our > favorite > former employee (haha). he'd done some modifications for them last summer, > and > it had never worked correctly! i had to weed thru 10 pages of tricky code, > without a single comment. a 3 excedrin special. > > nj > > > +--- > | This is the Midrange System Mailing List! > | To submit a new message, send your mail to MIDRANGE-L@midrange.com. > | To subscribe to this list send email to MIDRANGE-L-SUB@midrange om. > | To unsubscribe from this list send email to MIDRANGE-L-UNSUB@midrange.com. > | Questions should be directed to the list owner/operator: > david@midrange.com > +--- > > +--- > | This is the Midrange System Mailing List! > | To submit a new message, send your mail to MIDRANGE-L@midrange.com. > | To subscribe to this list send email to MIDRANGE-L-SUB@midrange.com. > | To unsubscribe from this list send email to MIDRANGE-L-UNSUB@midrange.com. > | Questions should be directed to the list owner/operator: david@midrange.com > +--- > +--- | This is the Midrange System Mailing List! | To submit a new message, send your mail to MIDRANGE-L@midrange.com. | To subscribe to this list send email to MIDRANGE-L-SUB@midrange.com. | To unsubscribe from this list send email to MIDRANGE-L-UNSUB@midrange.com. | Questions should be directed to the list owner/operator: david@midrange.com +---
As an Amazon Associate we earn from qualifying purchases.
This mailing list archive is Copyright 1997-2024 by midrange.com and David Gibbs as a compilation work. Use of the archive is restricted to research of a business or technical nature. Any other uses are prohibited. Full details are available on our policy page. If you have questions about this, please contact [javascript protected email address].
Operating expenses for this site are earned using the Amazon Associate program and Google Adsense.