Re: Critique requested for my first MI program

[leif@xxxxxxxxxxxxx]

> Enter MI.  Here is my very first MI program, so be gentle with your
> critique, but I am asking for constructive criticism
>     CMPBLA(B)    OPCODE,"SUB"/EQ(SUB);   /* Do SUB if parm 3 is */
>     CMPBLA(B)    OPCODE,"-  "/EQ(SUB);   /* either SUB or -     */

Your code is FINE. Welcome to MI-world.
One subtle point: instead of the string "-  " with two spaces
it is better to use a compare with pad:
CMPBLAP(B)   OPCODE,"-", " "/EQ...
that makes your code easier to maintain.
Imagine that for some reason you wanted to expand
OPCODE to 8 characters, all you would have to do
is to change its declaration if you use compare with
pad.

 


+---
| This is the MI Programmers Mailing List!
| To submit a new message, send your mail to MI400@midrange.com.
| To subscribe to this list send email to MI400-SUB@midrange.com.
| To unsubscribe from this list send email to MI400-UNSUB@midrange.com.
| Questions should be directed to the list owner/operator: dr2@cssas400.com
+---