Re: x5250 build failure -- LINUX5250

On Thu, 21 Oct 2004, Scott Klement wrote:

When I try to build x5250, I get two errors.

FIRST ERROR:

x5250.c: In function `main':
x5250.c:148: error: `LC_ALL' undeclared (first use in this function)
x5250.c:148: error: (Each undeclared identifier is reported only once
x5250.c:148: error: for each function it appears in.)

On my system, LC_ALL is declared in the file called locale.h.  In x5250.c
you have the following code:

#ifdef HAVE_LOCALE_H
#include <locale.h>
#endif

However, there's no code in configure.ac that would cause "HAVE_LOCALE_H"
to be defined.  I can fix this problem by applying the following patch to
configure.ac:

--- x5250-0.4.1.old/configure.ac    Tue Jun 29 14:29:50 2004
+++ x5250-0.4.1/configure.ac        Thu Oct 21 23:29:58 2004
@@ -47,7 +47,7 @@
# Checks for header files.
#
AC_HEADER_STDC
-AC_CHECK_HEADERS([stdlib.h unistd.h])
+AC_CHECK_HEADERS([stdlib.h unistd.h locale.h])

#
# Checks for typedefs, structures, and compiler characteristics.

Thank you for this patch. I'll add it in (I'm learning more about autoconf).

SECOND ERROR:

After solving the first error, I ./autogen.sh && configure && make and I
get the following error:

x5250.c: In function `place_graphics':
x5250.c:1170: error: structure has no member named `scrollbar'
*** Error code 1

Obviously, you must've patched lib5250 and added a scrollbar to the
Tn5250Terminal structure.  However, I can't find this patch on your Web
site. I'm running the latest tn5250 from CVS (I just checked it out again
to make sure) so I'm stuck.

I blew it with the 0.4.1 release. That piece of code is supposed to be surrounded with

#ifdef ENHANCED
...
#endif

and I mistakenly left that out. You're not the first one to run into that problem :( I have more time now, so maybe I should make a 0.4.2 release and fix these problems...

btw - the patch to tn5250 which enables scrollbar support (but *very* experimental/proof of concept) is at:

http://www.chowhouse.com/~james/x5250/enhanced.patch

I didn't have a link to it previously. I've fixed that now with a link to my patch from the main page:

http://www.chowhouse.com/~james/x5250/

James Rich

It's not the software that's free; it's you.
        - billyskank on Groklaw