RE: Re: Re: Tn5250 for Windows Memory Leak

Hi all

I didn't compile the win32 version and I'm not up to date so lines numbers may 
vary.
Still, in HEAD branch at line 1447 in win32_terminal_update_indicators():

       savepen = SelectObject(bmphdc, 
                   CreatePen(PS_SOLID, 0, colorlist[A_5250_RULER_COLOR].ref));

The created pen is never deleted! This is a memory leak. So just before the 
closing bracket, replace

       savepen = SelectObject(hdc, savepen);
   }

by
 
       savepen = SelectObject(hdc, savepen);
       DeleteObject(savepen);
   }

so the created pen gets deleted. This code is only active when the ruler is on 
so even though I didn't try it I'm pretty sure it is the fault.

Hope it helps

M-A


-----Original Message-----
From: linux5250-bounces@xxxxxxxxxxxx
[mailto:linux5250-bounces@xxxxxxxxxxxx]On Behalf Of Sean Porterfield
Sent: 9 janvier, 2004 15:30
To: Linux 5250 Development Project
Subject: RE: [LINUX5250] Re: Re: Tn5250 for Windows Memory Leak


> From: Scott Klement

> Try supplying +ruler in your tn5250rc file, and then see if the size gets
> larger...

Aha!  Started at 4680K then went to 4684K when I signed on.  After about 23
presses of F3 I got 4688K.  24 more and I got to 4692K.

I see just holding down an arrow key also causes the memory increase.  I've
never used the ruler because I can't stand to have it on all the time.  (I
just turn it on and off as needed in Client Access.)

_______________________________________________
This is the Linux 5250 Development Project (LINUX5250) mailing list
To post a message email: LINUX5250@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/linux5250
or email: LINUX5250-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/linux5250.