Re: Should application do connection.close()?

[James Perkins <jrperkinsjr@xxxxxxxxx>]

Well kind of....
The AS400JDBCConnectionPool.close() method says it will close ALL unused
database connections, essentially closing the pool and not the connection.

"Closes all the unused database connections in the pool."

To return the connection to the pool you have to call the close() method on
the connection not the pool. In the example you posted that is what's
happening, but I just wanted to clarify that.

Lim,
> From your past posts I assume this is a WebSphere application. If it is, you
should let WebSphere handle the connection pooling. I learned this same
thing from this list, so I just wanted to share.

A simple example:

    public Connection createConnection() throws NamingException,
SQLException {
        Connection connection = null;
        Hashtable<String, String> env = new Hashtable<String, String>();
        env.put(Context.INITIAL_CONTEXT_FACTORY,
                "com.ibm.websphere.naming.WsnInitialContextFactory");
        Context context = new InitialContext(env);
        DataSource datasource = (DataSource) context
                .lookup("jdbc/MyConnection");
        connection = datasource.getConnection();
        context.close();
        return connection;
    }


--
James R. Perkins


On Fri, Mar 20, 2009 at 13:24, Neill Harper <neill.harper@xxxxxxxx> wrote:

> The javadoc on the ibm site says that .close() returns the connection to
> the
> pool so you should deffo close it.
>
> // Obtain an AS400JDBCConnectionPoolDataSource object from JNDI.
>  Context context = new InitialContext(environment);
>  AS400JDBCConnectionPoolDataSource datasource =
> (AS400JDBCConnectionPoolDataSource)context.lookup("jdbc/myDatabase");
>
>  // Create an AS400JDBCConnectionPool object.
>  AS400JDBCConnectionPool pool = new AS400JDBCConnectionPool(datasource);
>
>  // Adds 10 connections to the pool that can be used by the application
> (creates the physical database connections based on the data source).
>  pool.fill(10);
>
>  // Get a handle to a database connection from the pool.
>  Connection connection = pool.getConnection();
>
>  ... Perform miscellenous queries/updates on the database.
>
>  // Close the connection handle to return it to the pool.
>  connection.close();
>
>  ... Application works with some more connections from the pool.
>
>  // Close the pool to release all resources.
>  pool.close();