RE: Source Evaluation?

["Clapham, Paul" <pclapham@xxxxxxxxxxxxx>]

Just a couple of comments:

  public void init(ServletConfig config) throws ServletException
  {
    super.init(config);
  }

This doesn't actually do anything, in the sense that if you left it out the
servlet's behaviour would be identical.  I suppose you might have a standard
servlet skeleton that included this, so if you needed initialization code
you could just plug it in.  But in my (limited) experience, I've found that
most of my servlets don't require an init() method.

    if (!Where.equals(""))

It must be too much exposure to the Sun, but I can't help seeing this as a
call to the static method equals() of class Where.  Sun's coding standards
say that variable names should start with a lower-case letter and class
names should start with an upper-case letter.  You seem to have mostly
followed those rules.  It occurs to me that since we have to use so many
classes from the Java APIs, which follow Sun's naming conventions, that's a
strong incentive to follow the same conventions in our own code.

PC2

-----Original Message-----
From: Stone, Brad V (TC) [mailto:bvstone@taylorcorp.com]
Sent: February 8, 2001 14:07
To: 'JAVA400-L@midrange.com'
Subject: RE: Source Evaluation?


Well, the first two want em posted, so here we go.  :)
I'll attach them to this mail.

Thanks everyone!  Be honest and let me know what I'm doing wrong, and maybe
at least one thing I'm doing right.  :)

Here's how it works.  getfilename.html calls getFileName which builds HTML
and another form and calls runSQL.

Brad



> -----Original Message-----
> From: tmalin@hannasteel.com [mailto:tmalin@hannasteel.com]
> Sent: Thursday, February 08, 2001 3:42 PM
> To: JAVA400-L@midrange.com
> Subject: Re: Source Evaluation?
> 
> 
> 
> Brad,
> 
>      Post them, so we all can learn. Ill give my two cents 
> and maybe learn
> something new in the process.
> 
> 
> Tom
> 
> 
> 
> 
> +---
> | This is the JAVA/400 Mailing List!
> | To submit a new message, send your mail to JAVA400-L@midrange.com.
> | To subscribe to this list send email to JAVA400-L-SUB@midrange.com.
> | To unsubscribe from this list send email to 
> JAVA400-L-UNSUB@midrange.com.
> | Questions should be directed to the list owner: joe@zappie.net
> +---
> 

+---
| This is the JAVA/400 Mailing List!
| To submit a new message, send your mail to JAVA400-L@midrange.com.
| To subscribe to this list send email to JAVA400-L-SUB@midrange.com.
| To unsubscribe from this list send email to JAVA400-L-UNSUB@midrange.com.
| Questions should be directed to the list owner: joe@zappie.net
+---