Re: First C program

Hi, Barbara, and Frank:

This reply is mostly "for the archives". ...

I think a much improved style for C code can be illustrated by slightly re-formatting your last code example, as shown below:

static _RFILE *fOpenFile( const char *filename,
const char *openmode,
int rc ) {
_RFILE *f;
f = _Ropen(filename, openmode);
if (f EQ NULL) {
printf("can't open file %s\n", PFILENAME);
exit(rc);
}
return f;
}

Basically, my recommendations boil down to:

1. indent just two or three spaces for each level of nesting (I prefer 3)

2. use the "{" and "}" even if only one statement or function is coded;

3. put "{" on the same line as the function header or structure declaration or "if " or "while " or "for" statement ...

4. place the corresponding "}" on a line by itself, indented to "line up" with the code above it

Here is an example of an if statement with an "else" clause:

if (x == y) {
printf("do something...\n");
}
else {
printf("do something else ...\n");
}

Here is another alternative:

if (x == y) {
printf("do something...\n");
} else {
printf("do something else ...\n");
}

Whatever you decide to do, strive for consistency.

All the best,

Mark S. Waterbury