Re: How do you read this code ?

Doug

I agree completely with you - since this does not seem to do anything, the question is, what was it meant to do? Many of us are saying the same thing.

Makes me wonder just how much data is corrupted - scary thought! I remember someone who shall remain nameless using a Y instead of an N and lots of executives did not get their checks. Hmmm! Fortunately it was noticed quickly - heh - and fixed just as quickly and rerun.

Vern

Douglas Handy wrote:

the free form converter does not change things much - does not add
parentheses - and/or precedence still controls it - and we are still
left with Joe's observation - this is a do-nothing condition, it seems.

While I agree Joe's observation means his simple one-liner performs the
equivalent function of the existing code, the fact they tried to setup the
IF construct makes me suspect the code isn't working as originally
intended. So Joe's simplified version may just be maintaining a previously
undetected bug.

If I saw something like that in code, before simplifying to Joe's method I
think it would be prudent to try to find out what the various fields and
codes mean and whether a (different and corrected) form of the IF statment
should be implemented. Using free form and parentheses around each AND set
and new lines for each OR condition can make the corrected code much easier
to follow.

Long live free format. :)

Doug