Re: Re writing CL in RPG

Hi
Below is my code. I am trying to replace copy commands program by writing
RPGLE.
Is this a good design , will this run faster? I would like to know your
opinions and suggestions.
Thank you for your time. The number of records in AFILE usually more than a
million.



LOOP: RCVF
MONMSG MSGID(CPF0864) EXEC(GOTO CMDLBL(END))

CPYF FROMFILE(*LIBL/ABC.FILE) +
TOFILE(*LIBL/XYZ.MONY) MBROPT(*ADD) +
INCREL((*IF MID *EQ &YID) (*AND +
MNAME *EQ &YNAME) (*AND MACCT *EQ &YACCT))
CPYF FROMFILE(*LIBL/AFILE) +
TOFILE(*LIBL/BFILE) MBROPT(*ADD) +
INCREL((*IF PID *EQ &YID) (*AND +
PNAME *EQ &YNAME) (*AND PACCT *EQ &YACCT))

GOTO CMDLBL(LOOP)

END: CPYF FROMFILE(*LIBL/ABC.FILE) +
TOFILE(*LIBL/XYZ.MONY) MBROPT(*ADD) +
INCREL((*IF MID *EQ F))
TOFILE(*LIBL/XYZ.MONY) MBROPT(*ADD) +
INCREL((*IF MID *EQ F))
CPYF FROMFILE(*LIBL/AFILE) +
TOFILE(*LIBL/BFILE) MBROPT(*ADD) +
INCREL((*IF PID *EQ F))


=========================
* Copy data from ABCFILE by ID, NAME, Acct
C k_idnamacc Setll ABCFILE
C Read ABCFILE
C DoW Not %Eof(ABCFILE) and MID = YID
C and MNAME = YNAME and MACCT = YAcct
C Write XYZMNYREC

C Read ABCFILE
C EndDo

* copy data from AFILE by ID, NAME, Acct
C k_idnamacc Setll AFILE
C Read AFILE
C DoW Not %Eof(AFILE) and PID = YID
C and PNAME = YNAME and PACCT = YAcct
C Write XYZPOSREC
C Read AFILE
C EndDo
*
C Read GEUKACT
C Enddo
*
* Copy ABCFILE records for ID F
C 'F' Setll ABCFILE
C Read ABCFILE
C DoW Not %Eof(ABCFILE) and MID = 'F'
C Write XYZMNYREC
C Read ABCFILE
C EndDo
*
* Copy AFILE records for ID F
C 'F' Setll AFILE
C Read AFILE
C DoW Not %Eof(AFILE) and PID = 'F'
C Write XYZPOSREC
C Read AFILE
C EndDo
*
C Eval *inlr = *on


C *InzSr Begsr

C k_idnamacc KList
C KFld YID
C KFld YNAME
C KFld YACCT

C Endsr

Donna.



--
This is the RPG programming on the AS400 / iSeries (RPG400-L) mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.