RE: CWCCVTDT continued....

I agree.

I used copy books for the PR definitions, as I always do. It's the
safest way.
I didn't show the copy book in the examples for clarity.

The actual code I'm working in would show /copy *LIBL/CPYSRC,FXM_F00015
in both programs.

I never like having duplicate literal code anywhere if I can avoid it.

Thanks for noticing.

JPW 

 

The bitterness of poor quality remains long after low pricing is
forgotten! 

 

Cautillo, Leon M.



-----Original Message-----
From: rpg400-l-bounces@xxxxxxxxxxxx
[mailto:rpg400-l-bounces@xxxxxxxxxxxx] On Behalf Of Barbara Morris
Sent: Wednesday, 1 March 2006 14:58
To: rpg400-l@xxxxxxxxxxxx
Subject: Re: CWCCVTDT continued....


Jim Wiant wrote:
> 
> Now - parent program for a called module:
> ...
> D FXM_Convert_Date_And_Time_Format...
> D                 PR            17A   Varying
> D InpFmt                        10A   Const
> ...
> C                   Eval      myOutVar =
> C                               FXM_Convert_Date_And_Time_Format(
> C                                 myInpFmt:myInpVar:myOutFmt:
> C                                 ERRC0100)
> ...
> And the module (compiled as type *module):
> ...
> D FXM_Convert_Date_And_Time_Format...
> D                 PR            17A   Varying
> D InpFmt                        10A   Const
> ...

Jim, you have the same prototype coded in two places.  You should really
have a prototype coded in only one source file, to get the maximum
parameter-protection from the compiler.  

As a rule of thumb: If the procedure is an internal subprocedure (no
EXPORT on the P spec), code the prototype within the module.  Otherwise,
code the prototype in a /copy file and copy it in whenever you need it.