Re: Should application do connection.close()?

Lim Hock-Chai wrote:

Looking at our code, I see that some of the methods of some classes
are using the AS400JDBCConnectionPool.getConnection() method to get a
java.sql.Connection object. Once the connection object is obtained,
should this same method call the connection.close() once it is
finished with it?

Yes, as this will release physical locks on objects that the connection has open.

In the case of a JDBC Connection pool, the AS400JDBCConnectionPool.close() method also returns the connection to the pool so it (potentially) can be reused. If you never close the connection, the connection won't be returned to the pool.

Or should it leave it to gc to call the finalize() method to
close/free it backs to the Connection Pool (I'm not even sure if
finalize() method is being override in the Connection class to return
connection back to the pool)? Am I even make sense?

Since the connection pool is managing the connection object, it will hold a reference to the connection until the pool is destroyed, so garbage collection will probably never consider it a candidate for finalization.

Also, don't depend on finalization to do anything ... if you need it to happen, do it yourself.

david